MLDonkey Forum Index
Homepage •  Bugs •  Tasks •  Patches •  SF.net Project Page •  ChangeLog •  German forum •  Links •  Wiki •  Downloads
 
 FAQFAQ   SearchSearch   MemberlistMemberlist   UsergroupsUsergroups   RegisterRegister 
 ProfileProfile   Log in to check your private messagesLog in to check your private messages   Log inLog in 
 
spiralvoice 28s:Little Bug in Web interface

 
Post new topic   Reply to topic    MLDonkey Forum Index -> Development
View previous topic :: View next topic  
Author Message
fabtar
Sage


Joined: 04 Feb 2004
Posts: 1575
Location: Italy

PostPosted: Mon Feb 14, 2005 12:59 pm    Post subject: spiralvoice 28s:Little Bug in Web interface Reply with quote

I have enabled, fasttrak, ed2k, ovr, kad (sometimes I have tried Gnutella without success).
I have noticed 2 errors in search panel.
If I select the network to search into, mldonlkey ignore such command by doing the search into all the connected networks!! (Yes I can find out reults from fastrak..ed2k toghether).
Another issue is about visualisation of results.
Mldonkey fail to visulaize the network from which the result is taken.
Yes in NETWORK field of the result's table there aren't D,F,G,or G2 but simply the symbol --.
In fact I'm able to recognise them(distinguish results) by teh link field of the table:
ed2k:\\blabla menas donkey result
sig.dat:\\sdasdas means kazza
g2:\\ gnutella and so on.

My question is...If the mldonkey is able to build the exact link , why is he not able to write the right Network's INFO???
Hope useful

P.s: There is little typo in statistic-kad : The network is kademlia..not overnet
Thanks for this great developement!!!
Back to top
View user's profile Send private message
fabtar
Sage


Joined: 04 Feb 2004
Posts: 1575
Location: Italy

PostPosted: Mon Feb 14, 2005 1:06 pm    Post subject: Reply with quote

I have noticed that fastrack's downloads are quite quick but 80% of downloads are corrupted.
Only one download is gone fine.
Back to top
View user's profile Send private message
spiralvoice
Sage


Joined: 06 Jan 2003
Posts: 3982
Location: Germany

PostPosted: Mon Feb 14, 2005 2:41 pm    Post subject: Re: spiralvoice 28s:Little Bug in Web interface Reply with quote

fabtar wrote:
Mldonkey fail to visulaize the network from which the result is taken.
Yes in NETWORK field of the result's table there aren't D,F,G,or G2 but simply the symbol --.

From driverInteractive.ml
Code:
(* TODO RESULT: use the uids to display from which networks it is downloadable
                  let n = network_find_by_num r.result_network in
              n.network_name *) "--")
          else Printf.bprintf  buf "[%5d] %s "
                  !counter

(* TODO RESULT:
              (let n = network_find_by_num r.result_network in
                  n.network_name) *)
                "--";

Seems we have work in progress here..., same code is in 2.5.29
Removing the comments and enabling the original code results in compile error:
Code:
Unbound record field label result_network

from g2Globals.ml
Code:
(* TODO: result_netfid, result_network *)

from g2Interactive.ml
Code:
(* TODO
let _ =
  result_ops.op_result_info <- (fun r ->
       {
        C.result_num = r.result_result.impl_result_num;
        C.result_network = network.network_num;

        C.result_names = [r.result_name];
        C.result_md4 = Md4.null;
        C.result_size = r.result_size;
        C.result_format = result_format_of_name r.result_name;
        C.result_type = result_media_of_name r.result_name;
        C.result_tags = r.result_tags @ (List.map (fun uid ->
            string_tag ("urn") (Uid.to_string uid)
        ) r.result_uids);
        C.result_comment = "";
        C.result_done = false;
      }
  )
*)

Similar deactived code is in donkeyInteractive.ml
fabtar wrote:
P.s: There is little typo in statistic-kad : The network is kademlia..not overnet

I know, but the statistic module (along others) is shared code between Overnet and Kademlia and I don't know how to fix this typo.
_________________
Link overview and precompiled cores here: http://mldonkey.sourceforge.net/DownloadLinks
Back to top
View user's profile Send private message
fabtar
Sage


Joined: 04 Feb 2004
Posts: 1575
Location: Italy

PostPosted: Mon Feb 14, 2005 3:13 pm    Post subject: Reply with quote

OK, thanks spralvoice, I'm testing hard to find leaks. =)
Seems some bugs are only feature in TODO state.
Thaks a lot
Back to top
View user's profile Send private message
Display posts from previous:   
Post new topic   Reply to topic    MLDonkey Forum Index -> Development All times are GMT
Page 1 of 1

 
Jump to:  
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum


Sourceforge.net Logo