ip_blocking_countries broken?

[blupp]

Hi, there.

Today i checked out the newest CVS and it seems to me that the ip-blocking of countries is broken. I'm not really sure which version i was using before that, but i think it was the cvs inclusive all patches until 22.05.2007. I am blocking "US" and some other countries.

Country statistics tell me:
United States:
Session seen: 107
Total seen: 126

Session Uptime: 3h
Total Uptime: 4d

MLNet 2.8.7.CVS: Multi-Network p2p client (Global Shares FileTP BitTorrent)

Anybody got similar experiences?

BTW: Thanks to anybody, who keeps mldonkey alive. Keep up the good work!

[spiralvoice]

You are only using BT? I am asking because you posted in the EDK forum.
You mentioned seen clients from the US, was any data transfered?

One hole is present in the IP blocking scheme, if you load the GeoIP database
via web_infos it takes ~15s after core start until the list is loaded.
Until then, the network modules are already working and clients from
blocked countries are able to connect.
_________________
Link overview and precompiled cores here: http://mldonkey.sourceforge.net/DownloadLinks

[blupp]

Yes, i'm only using bt at the moment. Disabled anything else at compile time. But i'm thinking that missing ip blocking would be a general problem. So posted in the 'general, ed2k, kad, overnet' forum

I know, that the country blocking doesn't work really perfect, especially at start up. (I estimated before, that the reason could be the geoip file, that has to be loaded). But after a short while clients from blocked countries vanished as up-/downloaders. Now i got them all the time.

Data is being transfert:
United States Up Down Seen
Session: 45.5M 60.5M 250
Total: 71.1M 154.2M 269
(remember: session is only 8 hours up)

I thought, somebody else would have noticed something similar already.
Maybe i should simple restart the client and see what happens?

[spiralvoice]

No, I will test it myself.
It is possible that the BT code lacks an IP block-check somewhere.
_________________
Link overview and precompiled cores here: http://mldonkey.sourceforge.net/DownloadLinks

[blupp]

In the past i also compiled only bt support in. At that time i havent had the impression that ip blocking wasn't working. So maybe the problem could be related to some newer patch.

Thanks for having a look into it.

[spiralvoice]

You could really have hit a stupid bug, please try this patch:

https://savannah.nongnu.org/patch/index.php?5992

If this solves the bug, I caught some "country_code = None | Some c"-magic wrong in patch #5940
_________________
Link overview and precompiled cores here: http://mldonkey.sourceforge.net/DownloadLinks

[blupp]

Have it running for around an hour and "feels" much like the old behavior. Only 4 US clients seen in this session yet and i noticed three of them right at startup. Should be validated over a longer period of time and somebody else. But for me the problem looks fixed right now.

Good work. Thanks, man!

[spiralvoice]

[spiralvoice]