MLDonkey Forum Index
Homepage •  Bugs •  Tasks •  Patches •  SF.net Project Page •  ChangeLog •  German forum •  Links •  Wiki •  Downloads
 
 FAQFAQ   SearchSearch   MemberlistMemberlist   UsergroupsUsergroups   RegisterRegister 
 ProfileProfile   Log in to check your private messagesLog in to check your private messages   Log inLog in 
 
Direct Connect support
Goto page Previous  1, 2, 3, 4, 5, 6, 7  Next
 
Post new topic   Reply to topic    MLDonkey Forum Index -> Problems with MLDonkey Client (Bittorrent, DirectConnect, Gnutella,...)
View previous topic :: View next topic  
Author Message
ygrek
professional


Joined: 20 Mar 2010
Posts: 521

PostPosted: Sun Aug 29, 2010 6:44 am    Post subject: Reply with quote

Quote:
What *is* the default target? I'm not seeing it in config/Makefile.in

Target all, see line 264, TARGET_TYPE gets defined in config/Makefile.config to either byte or opt.
Back to top
View user's profile Send private message Visit poster's website
somedamnthing
neophyte


Joined: 31 Jul 2010
Posts: 22

PostPosted: Mon Aug 30, 2010 8:23 am    Post subject: Reply with quote

I applied your patch and ran for a couple of hours. You'll find the log link at http://somedamnthing.org/mlnet.log.txt.

As for a valid magnet link:

Code:
magnet:?xt=urn:tree:tiger:NMYROOGP6ZI3T7FTQ7RW4VHYHGALTM2TV6V7QBQ


I cannot click these when they're in a chat window, of course, but the idea of being able to click the TTH hash and have mldonkey then search is not a bad one.

The links that are clickable are in Shared; these cause the browser to try to fire off a handler for the URL, which is invariably local software (DC++/Shakespeer/etc), which is what I'm trying to get away from with mldonkey.
Back to top
View user's profile Send private message
ygrek
professional


Joined: 20 Mar 2010
Posts: 521

PostPosted: Fri Sep 03, 2010 8:42 pm    Post subject: Reply with quote

Thanks for the log. Please try the following patch :
Code:

diff --git src/networks/direct_connect/dcShared.ml src/networks/direct_connect/dcShared.ml
index 073eb40..f6aa106 100644
--- src/networks/direct_connect/dcShared.ml
+++ src/networks/direct_connect/dcShared.ml
@@ -59,14 +59,14 @@ let make_mylist () =
       if dirname = "" then ntabs else begin
         buf_tabs buf ntabs;
         let dir = dirname in
-        Printf.bprintf buf "%s\r\n" dir;
+        Printf.bprintf buf "%s\r\n" (DcProtocol.utf_to_dc dir);
         ntabs+1
       end
     in
     List.iter (fun dcsh ->
       buf_tabs buf ntabs;
       let fname = Filename2.basename dcsh.dc_shared_codedname in
-      Printf.bprintf buf "%s|%Ld\r\n" fname dcsh.dc_shared_size
+      Printf.bprintf buf "%s|%Ld\r\n" (DcProtocol.utf_to_dc fname) dcsh.dc_shared_size
     ) node.shared_files;
     List.iter (fun (_, node) ->
         iter ntabs node
@@ -134,7 +134,7 @@ let file_to_che3_to_string filename =
 (* Compress string to Che3 and write to file *)
 let string_to_che3_to_file str filename =
   (try
-    let s = Che3.compress (DcProtocol.utf_to_dc str) in
+    let s = Che3.compress str in
     let wlen = 4096 in
     (*let str = String.create slen in*)
     let slen = String.length s in


Quote:

The links that are clickable are in Shared; these cause the browser to try to fire off a handler for the URL, which is invariably local software (DC++/Shakespeer/etc), which is what I'm trying to get away from with mldonkey.

I see. The idea behind these links was to simplify sharing of magnet links with humans (by copying with right-click browser menu). Probably the link should be made smaller or explicitely saying "copy". Suggestions welcome.
Back to top
View user's profile Send private message Visit poster's website
somedamnthing
neophyte


Joined: 31 Jul 2010
Posts: 22

PostPosted: Sat Sep 04, 2010 6:07 am    Post subject: Reply with quote

No good, still skyrockets to 100% shortly after service start. I'll update this post with a link to the log in a couple of hours. Let me know if you want a debug output.

I see what you're saying about the file links. The place I'm really looking for, with regards to the TTH handling I'm looking for, is after a file is found in an Extended Search. Once you select the file you want from the list of users with that file, a new search is spawned looking for type 'TTH' and the name is the hash of the file.

If hashes were parsed in that vein inside of chat windows, it would a) make my own humble scripting attempts much easier, and b) obviate the need I've had for a second browser tab open; one for the chat window, and one for the search function.


Edit: Here's the link to the mlnet log:
http://nerdlinger.org/files/mlnet.log.txt
Back to top
View user's profile Send private message
ygrek
professional


Joined: 20 Mar 2010
Posts: 521

PostPosted: Sun Sep 05, 2010 7:29 am    Post subject: Reply with quote

somedamnthing wrote:
No good, still skyrockets to 100% shortly after service start. I'll update this post with a link to the log in a couple of hours. Let me know if you want a debug output.
[...]
Edit: Here's the link to the mlnet log:
http://nerdlinger.org/files/mlnet.log.txt


Please double check that the above patch was used when compiling this binary. I used your shared_files_dc.ini (from private message) and observed high cpu usage without this patch and no problems (filelist created immediately) after the patch, so it definitely works here.
Back to top
View user's profile Send private message Visit poster's website
spiralvoice
Sage


Joined: 06 Jan 2003
Posts: 3982
Location: Germany

PostPosted: Sun Sep 05, 2010 9:30 am    Post subject: Reply with quote

somedamnthing wrote:
Also, you talked of stripping the binary, so I'd dug through the Makefiles, and found a bunch of 'strip' commands in config/Makefile.in. I commented out the one on line 1550, which gave me a perfectly debugable pre-installation binary. Sorry I didn't mention this one.

Currently this is line 1578 and is only called for make target "release.shared"
which creates release-ready tarballs. Just calling "make" or "make static"
will not strip the resulting binary. Compiling debug binaries for public release
using the specific make targets to create tarballs is not desired so I do not
think that removing the strip command in question surves any purpose.
_________________
Link overview and precompiled cores here: http://mldonkey.sourceforge.net/DownloadLinks
Back to top
View user's profile Send private message
spiralvoice
Sage


Joined: 06 Jan 2003
Posts: 3982
Location: Germany

PostPosted: Sun Sep 05, 2010 9:33 am    Post subject: Reply with quote

somedamnthing wrote:
As far as the FreeBSD Makefile environment is concerned, I noticed that the Makefile for the port has this line:

Code:
ALL_TARGET=     opt


which seems to correspond to release.shared.

No, it is vice versa, target "release.shared" depends on "opt".
Calling "make opt" is the same as "make" when Ocaml native code compiler
is available on the machine.
_________________
Link overview and precompiled cores here: http://mldonkey.sourceforge.net/DownloadLinks
Back to top
View user's profile Send private message
somedamnthing
neophyte


Joined: 31 Jul 2010
Posts: 22

PostPosted: Mon Sep 06, 2010 1:27 am    Post subject: Reply with quote

ygrek wrote:

Please double check that the above patch was used when compiling this binary. I used your shared_files_dc.ini (from private message) and observed high cpu usage without this patch and no problems (filelist created immediately) after the patch, so it definitely works here.


Yeah, looks like I mixed my patches up. I patched using this new one and it seems to be running just fine, no CPU delays. Thanks!
Back to top
View user's profile Send private message
spiralvoice
Sage


Joined: 06 Jan 2003
Posts: 3982
Location: Germany

PostPosted: Tue Sep 07, 2010 6:27 pm    Post subject: Reply with quote

somedamnthing wrote:
I patched using this new one and it seems to be running just fine, no CPU delays. Thanks!

committed to CVS:
http://article.gmane.org/gmane.network.mldonkey.cvs/3372
_________________
Link overview and precompiled cores here: http://mldonkey.sourceforge.net/DownloadLinks
Back to top
View user's profile Send private message
somedamnthing
neophyte


Joined: 31 Jul 2010
Posts: 22

PostPosted: Tue Sep 07, 2010 8:02 pm    Post subject: Reply with quote

My main feature requests at this point are, as discussed:

* Better username handling in http (specifically usernames containing spaces)
* Better magnet/TTH link handling in http (using some pre-existing functions maybe)
* Ability to clear private message logs in either http or telnet (think "closing a chat window")

I'm not sure if points 1 and 3 are DC specific. If not, let me know and I can move them into a more general thread.

Thanks again!
Back to top
View user's profile Send private message
ygrek
professional


Joined: 20 Mar 2010
Posts: 521

PostPosted: Sun Oct 31, 2010 9:39 pm    Post subject: Reply with quote

somedamnthing wrote:

* Better username handling in http (specifically usernames containing spaces)

Similar problem (in russian) - http://mldonkey.sourceforge.net/phpBB2/viewtopic.php?p=30846#30846
Possible solution - patch 1 and patch 2. Please test.
_________________
Download | Report bugs | git mirror
Back to top
View user's profile Send private message Visit poster's website
Mrko
neophyte


Joined: 20 Feb 2011
Posts: 4

PostPosted: Mon Feb 21, 2011 10:23 pm    Post subject: Reply with quote

I'm experiencing problems to connect to users using Mldonkey - DC:

Setup:
Qnap ts-112 (NAS)
Mldonkey 3.0.0 (installed via QPKG package)
Ports 4440-4450 have been forwarded to the NAS (Forwarding works; tested with DC++)
Default settings for DC: eg. port 4444 and firewall false

I managed to get some files in share and connect to several hubs. Dcinfo gives:
Hub supports NoGetINFO NoHello TTHSearch HubTopic
Client supports MiniSlots XmlBZList ADCGet TTHF
Mode: Active
Connected servers: 1

Problem:
'DCusers all' gives the full list of users in the hub, but I cannot download their filelists. DCclients gives as output: user none:0 DcDownloadListConnecting NoConnection None

In addition the search options doesn't work either.

DCinfo
Quote:
DC Info
Hub supports NoGetINFO NoHello TTHSearch HubTopic
Client supports MiniSlots XmlBZList ADCGet TTHF
All/Open slots 2 / 2
Mode Active
Connected servers 1
Server list: -==Senorita Vil_ga== (nick = dsaf) (uptime = 30m 19s48)
Hubs Normal:1 Vipped:0 Opped:0

Buildinfo
Version: MLNet Multi-Network p2p client version 3.0.0.CVS
SCM version: 2009-03-22 21:57:10
Networks: Global Shares Direct Connect FileTP BitTorrent Donkey (SUI)
Ocaml version: 3.10.2 - C compiler version: 4.2.4 - C++ compiler version: 4.2.4
Built on: Linux armv5tejl 2.6.24-1-versatile (little endian) with glibc 2.7
Configure args: '--enable-batch' '--enable-directconnect' '--disable-fasttrack' '--enable-checks'
Features: threads zlib-1.2.3.3 bzip2-1.0.5 gd(jpg/png-1.2.27) iconv(active) magic(active) check-bounds

Network Port Type
Core 4080 http_port
Core 4000 telnet_port
Core 4001 gui_port
Direct Connect 4444 client_port TCP+UDP

Runinfo
MLDonkey user: admin (PW Protected) - uptime: 35m 35s - running as administrators:admin
Enabled nets: DirectConnect
Server usage: enabled
Geoip: enabled, GeoLite data created by MaxMind, available from http://maxmind.com/
IP blocking: local: 0 ranges - web: 199903 ranges
Libmagic: file-type recognition database present
System info: Linux NAS-RVV 2.6.33.2 #1 Sat Feb 12 05:26:46 CST 2011 armv5tel
language: EN - locale: UTF-8 - UTC offset: +0100
max_string_length: 16777211 - word_size: 32 - max_array_length: 4194303 - max_int: 1073741823
max file descriptors: 1024 - max useable file size: 2^63-1 bits (do the maths ;-p)

Directory Type used free % free FS
/share/HDA_DATA/.qpkg/MLDonkey/.mldonkey core/ini files
32.52G 1.76T
98% ext2/3
/share/Qdownload/mldonkey/temp temp/downloading
32.52G 1.76T
98% ext2/3
incoming/directories shared (incoming_directories)
32.52G 1.76T
98% ext2/3
incoming/files shared (incoming_files)
32.52G 1.76T
98% ext2/3
/share/Qdownload/mldonkey/shared shared (all_files)
32.52G 1.76T
98% ext2/3
mlnet_tmp $MLDONKEY_TEMP
32.52G 1.76T
98% ext2/3
Back to top
View user's profile Send private message
ygrek
professional


Joined: 20 Mar 2010
Posts: 521

PostPosted: Tue Feb 22, 2011 8:01 am    Post subject: Reply with quote

Sorry, but this version is quite old - 2 years already - and there were some changes to DC plugin - maybe the issue is already fixed in current version. There are prebuilt 3.0.7 binaries for TS-119, maybe they will work on your device too (architecture and kernel version match)?
_________________
Download | Report bugs | git mirror
Back to top
View user's profile Send private message Visit poster's website
Mrko
neophyte


Joined: 20 Feb 2011
Posts: 4

PostPosted: Tue Feb 22, 2011 9:25 pm    Post subject: Reply with quote

ygrek wrote:
Sorry, but this version is quite old - 2 years already - and there were some changes to DC plugin - maybe the issue is already fixed in current version. There are prebuilt 3.0.7 binaries for TS-119, maybe they will work on your device too (architecture and kernel version match)?


Thanks, I installed it:

mlnet: error while loading shared libraries: libmagic.so.1: cannot open shared object file: No such file or directory

I tried to PM Korbus but PM function doesn't work :O
Back to top
View user's profile Send private message
ygrek
professional


Joined: 20 Mar 2010
Posts: 521

PostPosted: Wed Feb 23, 2011 8:38 am    Post subject: Reply with quote

Did you try this recipe :
Quote:
it may be necessary to add /opt/lib to the /etc/ld.so.conf and call ldconfig before running mldonkey, for it to find its libraries in the system.
?

Also I guess there should be qpkg for libmagic, or not?
_________________
Download | Report bugs | git mirror
Back to top
View user's profile Send private message Visit poster's website
Display posts from previous:   
Post new topic   Reply to topic    MLDonkey Forum Index -> Problems with MLDonkey Client (Bittorrent, DirectConnect, Gnutella,...) All times are GMT
Goto page Previous  1, 2, 3, 4, 5, 6, 7  Next
Page 6 of 7

 
Jump to:  
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum


Sourceforge.net Logo