MLDonkey Forum Index
Homepage •  Bugs •  Tasks •  Patches •  SF.net Project Page •  ChangeLog •  German forum •  Links •  Wiki •  Downloads
 
 FAQFAQ   SearchSearch   MemberlistMemberlist   UsergroupsUsergroups   RegisterRegister 
 ProfileProfile   Log in to check your private messagesLog in to check your private messages   Log inLog in 
 
Patch 6043 (Discover WAN IP) isn't working anymore!

 
Post new topic   Reply to topic    MLDonkey Forum Index -> Development
View previous topic :: View next topic  
Author Message
Berni
neophyte


Joined: 16 Dec 2006
Posts: 33
Location: Germany

PostPosted: Mon Aug 25, 2008 11:35 am    Post subject: Patch 6043 (Discover WAN IP) isn't working anymore! Reply with quote

Last year a patch was checked in here: http://savannah.nongnu.org/patch/?6043
However, this one is useless now. It uses http://ip.discoveryvip.com/ip.asp which does not show any IP adress anymore. I would suggest to use http://whatismyip.org/ instead as this is very reliable and no parsing is needed as just the IP is returned!
Back to top
View user's profile Send private message
spiralvoice
Sage


Joined: 06 Jan 2003
Posts: 3982
Location: Germany

PostPosted: Mon Sep 01, 2008 7:19 am    Post subject: Reply with quote

Fix committed to CVS: https://savannah.nongnu.org/patch/index.php?6628
_________________
Link overview and precompiled cores here: http://mldonkey.sourceforge.net/DownloadLinks
Back to top
View user's profile Send private message
Berni
neophyte


Joined: 16 Dec 2006
Posts: 33
Location: Germany

PostPosted: Thu Sep 11, 2008 12:11 am    Post subject: Reply with quote

I tested it for a few days and it works fine. Thanks for the patch!
Back to top
View user's profile Send private message
spiralvoice
Sage


Joined: 06 Jan 2003
Posts: 3982
Location: Germany

PostPosted: Tue Apr 10, 2012 6:32 pm    Post subject: Reply with quote

It seems the owner of whatismyip.org changed the rules as MLDonkeys IP discovery
does not work anymore: http://www.whatismyip.com/faq/automation.asp

Here is a proposed patch, based on the link above:
Code:
--- src/daemon/common/commonGlobals.ml   2010-11-01 18:19:23.000000000 +0100
+++ src/daemon/common/commonGlobals.ml   2012-04-10 20:24:25.000000000 +0200
@@ -836,7 +836,7 @@
       if !verbose then lprintf_nl "started IP discovery";
       let module H = Http_client in
       let r = { H.basic_request with
-        H.req_url = Url.of_string "http://whatismyip.org/";
+        H.req_url = Url.of_string "http://automation.whatismyip.com/n09230945.asp";
         H.req_proxy = !CommonOptions.http_proxy;
         H.req_max_retry = 10;
         H.req_user_agent = get_user_agent () }

I think MLDonkey on its own obeys the rules of whatismyip.org as it only optionally
checks for WAN IP on startup and when SIGHUP is received. I hope no 3rd party
script does something else Wink
_________________
Link overview and precompiled cores here: http://mldonkey.sourceforge.net/DownloadLinks
Back to top
View user's profile Send private message
spiralvoice
Sage


Joined: 06 Jan 2003
Posts: 3982
Location: Germany

PostPosted: Wed May 23, 2012 5:50 pm    Post subject: Reply with quote

spiralvoice wrote:
Here is a proposed patch

committed to CVS
http://mldonkey.sourceforge.net/forums/viewtopic.php?p=31974#31974
_________________
Link overview and precompiled cores here: http://mldonkey.sourceforge.net/DownloadLinks
Back to top
View user's profile Send private message
Sandokan
neophyte


Joined: 08 May 2008
Posts: 19
Location: Italy

PostPosted: Fri May 25, 2012 9:35 pm    Post subject: Reply with quote

Could be possible to set ip discovery address in downloads.ini as for web infos?

This could prevent recompiling the binaries to change only a simple string address.

Sandokan.
Back to top
View user's profile Send private message
Serge_K
neophyte


Joined: 08 Oct 2010
Posts: 43
Location: Moscow, Russia

PostPosted: Thu Feb 07, 2013 7:14 am    Post subject: Reply with quote

IP discovery doesn't work any more.

Code:

2013/02/06 23:11:09 [cO] downloaded IP discovery page, parsing...
2013/02/06 23:11:09 [cO] IP discovery parse error: Not_found
Back to top
View user's profile Send private message
Display posts from previous:   
Post new topic   Reply to topic    MLDonkey Forum Index -> Development All times are GMT
Page 1 of 1

 
Jump to:  
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum


Sourceforge.net Logo