MLDonkey Forum Index
Homepage •  Bugs •  Tasks •  Patches •  SF.net Project Page •  ChangeLog •  German forum •  Links •  Wiki •  Downloads
 
 FAQFAQ   SearchSearch   MemberlistMemberlist   UsergroupsUsergroups   RegisterRegister 
 ProfileProfile   Log in to check your private messagesLog in to check your private messages   Log inLog in 
 
New release: MLDonkey 3.1.4/5
Goto page 1, 2  Next
 
Post new topic   Reply to topic    MLDonkey Forum Index -> Development
View previous topic :: View next topic  
Author Message
spiralvoice
Sage


Joined: 06 Jan 2003
Posts: 3999
Location: Germany

PostPosted: Mon Mar 10, 2014 5:14 pm    Post subject: New release: MLDonkey 3.1.4/5 Reply with quote

Quote:
2014/03/22: version 3.1.5 = tag release-3-1-5
8415: Revert patch #8328 to fix GTK2 gui's compilation (ygrek)


Quote:
2014/03/10: version 3.1.4 = tag release-3-1-4
8388: BT: use porttest service from EDK module (ygrek)
8352: CryptoPP: Fix compilation with gcc-4.7 (Jaakko Perttilä)
8351: CryptoPP: Fix FreeBSD build with clang on i386 (tijl)
8350: CryptoPP: Fix compilation on armhf (ygrek)

2014/02/23:
8336: GD: Fix linking to libpng & libjpeg
8335: Version bump miniupnpc 1.9 (ygrek)
8334: Version bump libnatpmp 20131126 & miniupnpc 1.8 (ygrek)
8333: Config: New configure option --enable-dev (ygrek)
8332: New option "all" for command verify_chunks (ygrek)
8331: printf2: add ?exn parameter for easy exception printing (ygrek)
8330: printexc2: reduce complexity, drop unused code (ygrek)
8329: printf2: reduce complexity, use Printf.ksprintf (ygrek)
8328: gettext: reduce complexity, drop unused code (ygrek)
8327: GTK2 GUI: fix wrong url on splash screen (ygrek)
8326: BT: disable announcing to 127.0.0.1 (ygrek)
8325: do not reset option pause_new_downloads at startup (ygrek)
8324: BT: dump failing UDP tracker packets (ygrek)
8323: Config: fix minor typos (ygrek)
7916: Use GNU make when compiling upnp/natpmp on FreeBSD (zbroyar)

2013/07/20:
8123: configure: Fix GD version check for GD 2.1.x

2013/07/07:
8115: Use magnet: links without dllink
8114: Fix --enable-force-ocaml with Ocaml 4.00.x
8111: http: New option http_root_url specifies root url for the web interface (ygrek)
8113: IP discover: Fix broken URL
8112: BT/HTML: select/unselect whole directories in BT multifile downloads (ygrek)
8110: http_server: refactor error_page (ygrek)
8109: FTP: fix CWD (ygrek)
8108: FTP: fix authentication (ygrek)
8107: HTML: fix "Request URI too large" errors (ygrek)
drop unused selectPriority parameters
8106: EDK: do not dump unknown messages by default (ygrek)
8105: Config: report line and position for syntax errors in config files (ygrek)
8104: BT: suppress warning for peers6 entry in tracker response (ygrek)
7954: Fix handling of full disc (jcea)
7917: Allow upnp_stub.c to be compiled on Mac OS X (zbroyar)

_________________
Link overview and precompiled cores here: http://mldonkey.sourceforge.net/DownloadLinks


Last edited by spiralvoice on Sat Mar 22, 2014 11:12 am; edited 1 time in total
Back to top
View user's profile Send private message
anatolik
neophyte


Joined: 10 Mar 2014
Posts: 4

PostPosted: Mon Mar 10, 2014 10:05 pm    Post subject: Re: New release: MLDonkey 3.1.4 Reply with quote

Thanks for the new release!

When I try it to compile on Linux Arch I get a compilation error:
Quote:
File "src/networks/donkey/donkeyMftp.ml", line 170, characters 23-24:
Warning 3: deprecated feature: operator (&); you should use (&&) instead
File "src/gtk2/gui/guiMessages.ml", line 197, characters 38-46:
Error: Unbound module T
Makefile:5444: recipe for target 'src/gtk2/gui/guiMessages.cmx' failed


It might happen because we use the latest versions of software and newest ocaml compiler is stricter or something like this. I have not had problems with 3.1.3.

There are other compiler warnings that you might find interesting and want to fix it. Here is full build log https://gist.githubusercontent.com/anatol/9475431/raw/4628e09051e489ca3666b4fe952739ab6c2cd49d/mldonkey-3.1.4-1-x86_64-build.log
Back to top
View user's profile Send private message
ygrek
professional


Joined: 20 Mar 2010
Posts: 594

PostPosted: Tue Mar 11, 2014 2:49 am    Post subject: Reply with quote

No, that's an actual error, overlooked. Bad commit is gettext: reduce complexity, drop unused code (patch #8328). Reverting it should fix the problem.
_________________
Download | Report bugs | git mirror
Back to top
View user's profile Send private message Visit poster's website
anatolik
neophyte


Joined: 10 Mar 2014
Posts: 4

PostPosted: Tue Mar 11, 2014 3:29 am    Post subject: Reply with quote

ygrek wrote:
No, that's an actual error, overlooked. Bad commit is gettext: reduce complexity, drop unused code (patch #8328). Reverting it should fix the problem.


Do you plan to make a fixed release soon or one should use the revert commit for packaging?
Back to top
View user's profile Send private message
ygrek
professional


Joined: 20 Mar 2010
Posts: 594

PostPosted: Tue Mar 11, 2014 3:37 am    Post subject: Reply with quote

I believe spiralvoice will do a release soon, but you can safely revert the patch for packaging because it doesn't influence operation.
_________________
Download | Report bugs | git mirror
Back to top
View user's profile Send private message Visit poster's website
anatolik
neophyte


Joined: 10 Mar 2014
Posts: 4

PostPosted: Tue Mar 11, 2014 4:08 am    Post subject: Reply with quote

ygrek wrote:
I believe spiralvoice will do a release soon, but you can safely revert the patch for packaging because it doesn't influence operation.


Revert commit does not clearly apply to 3.1.4 sourcetree

Quote:
patching file src/daemon/common/commonMessages.ml
patching file src/daemon/driver/driverCommands.ml
patching file src/daemon/driver/driverControlers.ml
Hunk #1 succeeded at 1296 (offset 1 line).
patching file src/utils/lib/gettext.ml4
Hunk #5 FAILED at 319.
1 out of 6 hunks FAILED -- saving rejects to file src/utils/lib/gettext.ml4.rej
patching file src/utils/lib/gettext.mli
Hunk #1 FAILED at 17.
1 out of 1 hunk FAILED -- saving rejects to file src/utils/lib/gettext.mli.rej


Ok, I'll better wait for an official fixed release.
Back to top
View user's profile Send private message
ygrek
professional


Joined: 20 Mar 2010
Posts: 594

PostPosted: Tue Mar 11, 2014 8:16 am    Post subject: Reply with quote

Here is the fix
_________________
Download | Report bugs | git mirror
Back to top
View user's profile Send private message Visit poster's website
ygrek
professional


Joined: 20 Mar 2010
Posts: 594

PostPosted: Tue Mar 11, 2014 8:25 am    Post subject: Reply with quote

spiralvoice, I have a reservation regarding
Quote:
8388: BT: use porttest service from EDK module

it will not work for BT because it is a EDK-specific porttest service. This is fixed by other two commits that switch everything to using protocol-independent porttest (hosted by me eventually).
_________________
Download | Report bugs | git mirror
Back to top
View user's profile Send private message Visit poster's website
mstm
neophyte


Joined: 11 Nov 2012
Posts: 38

PostPosted: Tue Mar 11, 2014 9:51 pm    Post subject: Reply with quote

Many thanks Very Happy
Back to top
View user's profile Send private message
mstm
neophyte


Joined: 11 Nov 2012
Posts: 38

PostPosted: Wed Mar 19, 2014 8:48 pm    Post subject: Reply with quote

anatolik wrote:
Ok, I'll better wait for an official fixed release.


Hi, there are news?
Thanks
Back to top
View user's profile Send private message
anatolik
neophyte


Joined: 10 Mar 2014
Posts: 4

PostPosted: Thu Mar 20, 2014 2:19 pm    Post subject: Reply with quote

mstm wrote:
Hi, there are news?
Thanks

Yeah, it is sad to see that the team makes a release with compilation errors. Does it mean that they did not test before giving it to public?

And the problem still not fixed 10 days after this broken release Sad
Back to top
View user's profile Send private message
ygrek
professional


Joined: 20 Mar 2010
Posts: 594

PostPosted: Fri Mar 21, 2014 2:58 am    Post subject: Reply with quote

Quote:
Yeah, it is sad to see that the team makes a release with compilation errors. Does it mean that they did not test before giving it to public?

That's hilarious. There was a week for testing before release but obviously nobody actually bothered to test it at that time, so nobody cares, so what's the problem? The complains will not solve the problem, let's better think of how to improve the situation e.g. testing before release by all interested parties. Hint: "team" has only so much resources (~0.1 person/week) and any help is greatly appreciated.

Quote:
And the problem still not fixed 10 days after this broken release

The problem was fixed in less than 24h.
_________________
Download | Report bugs | git mirror
Back to top
View user's profile Send private message Visit poster's website
mstm
neophyte


Joined: 11 Nov 2012
Posts: 38

PostPosted: Fri Mar 21, 2014 5:41 pm    Post subject: Reply with quote

Thanks guys Wink
Back to top
View user's profile Send private message
spiralvoice
Sage


Joined: 06 Jan 2003
Posts: 3999
Location: Germany

PostPosted: Sat Mar 22, 2014 11:17 am    Post subject: Reply with quote

anatolik wrote:
And the problem still not fixed 10 days after this broken release Sad

Just released 3.1.5 to fix the GTK GUI2 compile bug.

Btw, between the broken commit and the release of 3.1.4 were
two weeks time for testing. It seems you did not react upon my
test request Wink
http://mldonkey.sourceforge.net/forums/viewtopic.php?p=32442#32442
_________________
Link overview and precompiled cores here: http://mldonkey.sourceforge.net/DownloadLinks
Back to top
View user's profile Send private message
FF44
neophyte


Joined: 26 Jan 2010
Posts: 3

PostPosted: Sun Mar 23, 2014 11:15 am    Post subject: Compil error with OS X Mavericks Reply with quote

Hi,
Cannot finalize compilation
Xcode 5.1
- OCaml version 4.01.0
- gcc version 4.2.1
- g++ version 4.2.1

First warnings while ./configure:
Quote:
checking for wget... no
wget.c:114:9: warning: implicit declaration of function 'close' is invalid in
C99 [-Wimplicit-function-declaration]
close(f);
^
wget.c:130:6: warning: implicit declaration of function 'write' is invalid in
C99 [-Wimplicit-function-declaration]
write(fd, buf, strlen(buf));
^
wget.c:132:20: warning: implicit declaration of function 'read' is invalid in
C99 [-Wimplicit-function-declaration]
while((nread = read(fd, buf, 1)) > 0){
^
3 warnings generated.
checking for wget... /Documents/mldonkey-3.1.5/config/wget


Second error while Make:
Quote:
clang: error: unknown argument: '-fno-defer-pop' [-Wunused-command-line-argument-hard-error-in-future]
clang: note: this will be a hard error (cannot be downgraded to a warning) in the future
make: *** [src/utils/cdk/zlibstubs.o] Error 2

Any idea?
Thanks
Back to top
View user's profile Send private message
Display posts from previous:   
Post new topic   Reply to topic    MLDonkey Forum Index -> Development All times are GMT
Goto page 1, 2  Next
Page 1 of 2

 
Jump to:  
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum


Sourceforge.net Logo